Fix SSL Handshake Issue #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the same "fix" I used for a couple other plugins as well. The only other workaround I know of is adding the |
|
Including requests as a external lib in Libraries/Shared was my first approach, and it worked in the init.py code, but for some reason the URL handler service still couldn't import requests. Do external libraries for URL handler services go somewhere else? I've struggled to find good documentation of the plex plugin framework. |
|
Libraries go in To import 3rd party libraries you need to add this to the plugin's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBS Kids has changed their page to now require SSL for all requests. The Plex plugin framework uses an old version of python and urllib2 that has issues with SSL, specifically SNI validation. Previously this issue was bypassed by making requests over http. This is no longer an option.
This work-around creates an SSL context that will not perform validation and uses it for all requests, preventing the handshake errors that the current plugin is getting.
This means that the SSL traffic could be vulnerable to man-in-the-middle attacks, but previously this traffic was entirely unencrypted, so I believe SSL with potential vulnerabilities is an acceptable solution.
I would not recommend using this solution for any plugin that is transmitting passwords or other sensitive information.